Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: swap bl for uint8arraylist #11

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

achingbrain
Copy link
Collaborator

bl brings the buffer polyfill, node streams deps and a bunch of
other stuff, and has a big API that we don't really use any of.

Swap for the uint8arraylist module which only really concentrates
on appending byte arrays, slicing them and consuming bytes from them.

BREAKING CHANGE: where BufferLists were returned, now Uint8ArrayLists are

`bl` brings the buffer polyfill, node streams deps and a bunch of
other stuff, and has a big API that we don't really use any of.

Swap for the `uint8arraylist` module which only really concentrates
on appending byte arrays, slicing them and consuming bytes from them.

BREAKING CHANGE: where `BufferList`s were returned, now `Uint8ArrayList`s are
@achingbrain achingbrain changed the title fix: swap bl for uint8arraylis fix: swap bl for uint8arraylist Feb 16, 2022
@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #11 (cb03049) into master (08d4134) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
- Coverage   89.33%   89.29%   -0.04%     
==========================================
  Files           2        2              
  Lines         300      299       -1     
  Branches       38       39       +1     
==========================================
- Hits          268      267       -1     
  Misses         32       32              
Flag Coverage Δ
chrome 100.00% <100.00%> (ø)
node 89.29% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)
test/test.spec.ts 87.04% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37419e1...cb03049. Read the comment docs.

@achingbrain achingbrain merged commit f1b4d33 into master Feb 16, 2022
@achingbrain achingbrain deleted the fix/swap-bl-for-uint8arraylist branch February 16, 2022 17:04
github-actions bot pushed a commit that referenced this pull request Feb 16, 2022
## [5.0.0](v4.0.2...v5.0.0) (2022-02-16)

### ⚠ BREAKING CHANGES

* where `BufferList`s were returned, now `Uint8ArrayList`s are

### Bug Fixes

* swap bl for uint8arraylist ([#11](#11)) ([f1b4d33](f1b4d33))
@github-actions
Copy link

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant