fix!: do not create unnecessary async work #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crossing async boundaries is not free, so when this module is passed synchronous pipeline stages, do not wrap them in async generators to keep them synchronous. BREAKING CHANGE: when the entire pipeline is synchronous, the return value will now be synchronous
alanshaw
approved these changes
Mar 30, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Mar 31, 2023
## [3.0.0](v2.0.5...v3.0.0) (2023-03-31) ### ⚠ BREAKING CHANGES * when the entire pipeline is synchronous, the return value will now be synchronous ### Bug Fixes * do not create unnecessary async work ([#66](#66)) ([e583174](e583174))
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@achingbrain This actually caused quite a lot of changes (no exported Transform type, for example) - could you post more info about what changed here and how to migrate? Thanks! I use this here, maybe I'm doing something that I shouldn't w.r.t. using the wrong Transform type: https://github.com/aperturerobotics/starpc/blob/main/srpc/packet.ts#L40 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crossing async boundaries is not free, so when this module is passed synchronous pipeline stages, do not wrap them in async generators to keep them synchronous.
BREAKING CHANGE: when the entire pipeline is synchronous, the return value will now be synchronous