Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add restore volume service (#2773) #2776

Merged
merged 1 commit into from
Dec 28, 2024
Merged

feat: Add restore volume service (#2773) #2776

merged 1 commit into from
Dec 28, 2024

Conversation

alandtse
Copy link
Owner

No description provided.

@alandtse alandtse merged commit 8eb8882 into master Dec 28, 2024
8 of 9 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12524763180

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 6 of 24 (25.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.09%) to 9.42%

Changes Missing Coverage Covered Lines Changed/Added Lines %
custom_components/alexa_media/services.py 5 23 21.74%
Files with Coverage Reduction New Missed Lines %
custom_components/alexa_media/services.py 2 30.56%
Totals Coverage Status
Change from base Build 12450004165: 0.09%
Covered Lines: 325
Relevant Lines: 3450

💛 - Coveralls

@alandtse
Copy link
Owner Author

@danielbrunt57 Please note your strings.json is incomplete and is breaking hassfest.

Error: R] [SERVICES] Service restore_volume has no name and is not in the translations file

Please fix and submit a PR.

@danielbrunt57
Copy link
Collaborator

@danielbrunt57 Please note your strings.json is incomplete and is breaking hassfest.

Error: R] [SERVICES] Service restore_volume has no name and is not in the translations file

Please fix and submit a PR.

I'm confused. My strings.json has "restore_volume".
I also had to modify translations/en.json as well for the checks to succeed.

image

image

@alandtse
Copy link
Owner Author

You don't have a name field.

@danielbrunt57
Copy link
Collaborator

danielbrunt57 commented Dec 30, 2024

Yes I do: "name": "Restore Previous Volume"...

    "restore_volume": {
      "description": "Restore previous volume level on Alexa media player device",
      "fields": {
        "entity_id": {
          "description": "Entity to restore the previous volume level on",
          "name": "Select media player:"
        }
      },
      "name": "Restore Previous Volume"
    },

It's just not in the same order as the other two services. Is that the reason for the error?

    "force_logout": {
      "name": "Force Logout",
      "description": "Force account to logout. Used mainly for debugging.",
      "fields": {
        "email": {
          "name": "Email address",
          "description": "Accounts to clear. Empty will clear all."
        }
      }
    },

@alandtse
Copy link
Owner Author

I don't know. Please figure it out. Hassfest breaking is a problem and I'll just revert the PR if it's not solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants