Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Euler integrator (Cython implementation) - speed issues #88

Open
mark-hobbs opened this issue Jul 12, 2021 · 1 comment
Open

Euler integrator (Cython implementation) - speed issues #88

mark-hobbs opened this issue Jul 12, 2021 · 1 comment
Assignees

Comments

@mark-hobbs
Copy link
Collaborator

The Cython implementation of the Euler integrator is 30x slower than equivalent vectorised Matlab code. It is also extremely limited and only allows for a linear damage model with no damping. It is important that there is a reasonably fast solver that does not require OpenCL. I propose to use Numba (jit compiler) instead of Cython. Initial testing shows that it is faster and does not require C like syntax that some users will be unfamiliar with.

@mark-hobbs mark-hobbs self-assigned this Jul 12, 2021
@bb515
Copy link
Collaborator

bb515 commented Jul 21, 2021

Sounds like a good feature - so will the Numba part will be for calculating the force vector, rather than doing the ODE (time integration)?

For the non-OpenCL ODE solve, could we use an existing integrator for the time integration parts? e.g., from scipy.integrate. Sometimes the advice given is "never write your own ODE solver".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants