-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add implementation of scitype
for "points on a manifold"
#128
Comments
Specifically: ST.scitype(::Tuple{Any,MT}) where MT<:ManifoldsBase.Manifold = ManifoldPoint{MT} This is implemented on the |
@mateuszbaran @kellertuer I propose you add MLJScientificTypes to your dev project and pin to the manifolds branch until we're sure this is the best approach. Yes? |
I think that looks good and should work. |
Been a while. Here's an update from our end: The JuliaAI/MLJScientificTypes.jl@4411140 And I can create a new PR if there is still interest to do some integration. What is the status of this at your end? |
We would still be interested of course – I just got carried away from the ManifoldsML package due to a few features on Manifolds and moving to a new university/country. |
Thanks for an update! I'm still interested in developing ManifoldsML further, it just happened that I don't currently need to apply traditional machine learning to manifold-valued data. I'm currently working towards continuous normalizing flows on manifolds because it's more relevant to one of the projects I'm currently working on. |
The tentative suggestion is that
scitype((p, M)) = ManifoldPoint{typeof(M)}
wheneverM isa Manifolds.Manifold
.Context:JuliaManifolds/ManifoldML.jl#3
Requires: #114
The text was updated successfully, but these errors were encountered: