-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker container doesn't build #1153
Comments
+1 |
have you tried to remove the "&& npm run clean " command? It doesnt work for me either, |
@japrogramer are you able to share you dockerfile and .dockerignore? also have you tried this again since the recent switch from ng2-admin to ngx-admin? |
well, I just did a pull and there doesn't seem to be a docker file in master. |
oh i hadn't noticed that. i made my own docker file that works as long as you set host and port properly:
|
I tried your docker file, and it does work and it does serve .. Im probably exposing the ports incorrectly, I can not access the site from outside the container but from within the container using curl I can see that it does serve the site ..
|
Oh i ended up overriding the cmd since im using docker compose. Try running ng serve from bin as in node_modules/.bin/ng serve --host 0.0.0.0 --port 4200 |
That worked! but only when accessing the site from the same computer, when I try to access the page from my laptop while running on my desktop It says. |
We can probably close this then unless maintainers want to add back andockerfile whoch incam do in a PR |
probably a good Idea to do a pull request now. everything seems to work, except for that invalid host header error, but that can probably be fixed later. |
edit package.json |
I'm submitting a ...
[ X] bug report
[ ] feature request
[ ] question about the decisions made in the repository
Do you want to request a feature or report a bug?
Hello i would like to report a bug
What is the current behavior?
current behavior is that it crashes while building the docker container
$docker build -t ng2 .
I expect the image to be built
4.11.6-3-ARCH
linux 4.11.6-3
Docker version 17.05.0-ce, build 89658bed64
The text was updated successfully, but these errors were encountered: