Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix create *.metadata.json when build release #801

Merged
merged 1 commit into from
Jun 5, 2018

Conversation

infuse89
Copy link
Contributor

No description provided.

@infuse89
Copy link
Contributor Author

infuse89 commented Jun 1, 2018

@nnixaa could you review PR?

@fmpierce
Copy link

fmpierce commented Jun 1, 2018

I hope this gets merged soon... :)

@nnixaa nnixaa merged commit 96ad9d2 into akveo:master Jun 5, 2018
@fmpierce
Copy link

fmpierce commented Jun 6, 2018

Please release this. I need it.

@razfriman
Copy link

I agree with @fmpierce. This fixes a CRITICAL bug which renders ng2-smart-table to NOT BUILD under release mode.

@sathyakps
Copy link

Can you please release this version. Can't Build my application after upgrading to Angular 6.

@nnixaa
Copy link
Contributor

nnixaa commented Jun 12, 2018

Done! Sorry for the delay!

@fmpierce
Copy link

fmpierce commented Jun 12, 2018

I'm still getting an error when I build on Angular6, AngularCLI 6.0.7, with the --prod flag:

ERROR in : Unexpected value 'Ng2SmartTableModule ... Please add a @NgModule annotation.

When I build using --prod and I use --aot=false --build-optimizer=false it builds fine. This error seems to happen due to aot flag when the build is converting html and typescript files into javascript.

https://angular.io/guide/aot-compiler

Should I create a new issue?

Any ideas?

@infuse89
Copy link
Contributor Author

infuse89 commented Jun 12, 2018

@fmpierce try to set version 1.3.1 in this version works with flag --prod and --aot but not working ng serve and i dont know why

@fmpierce
Copy link

@infuse89 I tried that and got a different error.

@infuse89
Copy link
Contributor Author

@fmpierce what error on version 1.3.1?

@fmpierce
Copy link

fmpierce commented Jun 12, 2018

@infuse89

ERROR in : "let-" is only supported on ng-template elements. ("
  </thead>
  <tbody>
    <template ngFor [ngForOf]="rows" [ERROR ->]let-rowz="$implicit" let-index="index">
      <tr *ngIf="!(datePicker.onlyCurrentMonth && rowz[0].sec")
: "let-" is only supported on ng-template elements. ("
  </thead>
  <tbody>
    <template ngFor [ngForOf]="rows" let-rowz="$implicit" [ERROR ->]let-index="index">
      <tr *ngIf="!(datePicker.onlyCurrentMonth && rowz[0].secondary && rowz[6].sec")

@infuse89
Copy link
Contributor Author

@fmpierce this is not a smart-table module error, this is error in another module

@fmpierce
Copy link

Version 1.3.3 builds with --prod now. Thanks!

The error I shared above was for ngx-bootstrap. Once I upgraded to version 2.0.5 it went away. Thanks for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants