-
Notifications
You must be signed in to change notification settings - Fork 878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix create *.metadata.json when build release #801
Conversation
@nnixaa could you review PR? |
I hope this gets merged soon... :) |
Please release this. I need it. |
I agree with @fmpierce. This fixes a CRITICAL bug which renders ng2-smart-table to NOT BUILD under release mode. |
Can you please release this version. Can't Build my application after upgrading to Angular 6. |
Done! Sorry for the delay! |
I'm still getting an error when I build on Angular6, AngularCLI 6.0.7, with the --prod flag: ERROR in : Unexpected value 'Ng2SmartTableModule ... Please add a @NgModule annotation. When I build using --prod and I use --aot=false --build-optimizer=false it builds fine. This error seems to happen due to aot flag when the build is converting html and typescript files into javascript. https://angular.io/guide/aot-compiler Should I create a new issue? Any ideas? |
@fmpierce try to set version 1.3.1 in this version works with flag --prod and --aot but not working ng serve and i dont know why |
@infuse89 I tried that and got a different error. |
@fmpierce what error on version 1.3.1? |
|
@fmpierce this is not a smart-table module error, this is error in another module |
Version 1.3.3 builds with --prod now. Thanks! The error I shared above was for ngx-bootstrap. Once I upgraded to version 2.0.5 it went away. Thanks for your patience. |
No description provided.