Added basic testing framework #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bump? If you are not interested I will simple close the PR and leave it on my own fork. |
|
Sorry! It looks like github defaulted notifications off (at work I use bitbucket so rarely login here). I will take a look, and either comment (or merge) tonight. |
|
This all looks good, thanks. I've merged locally and will push out a release this week with your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the basic boilerplate to test this module with:
It also includes .travis stuff which integrates well with Github.
I also changed the install class from "package" to "install" and keyed off of
$::osfamilyinstead of$::operatingsystemto conform to more standard module best practice stuff. (hope that is ok)Closes #7.