Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal separate row borders #69

Closed
yarax opened this issue Jan 13, 2016 · 5 comments
Closed

Horizontal separate row borders #69

yarax opened this issue Jan 13, 2016 · 5 comments

Comments

@yarax
Copy link

yarax commented Jan 13, 2016

At some point I noticed, that grey borders between rows disappeared. So I created a new project from scratch, using basic example

'use strict';

var React = require('react-native');
var { AppRegistry } = React;
var TableView = require('react-native-tableview');
var Section = TableView.Section;
var Item = TableView.Item;

class AwesomeProject extends React.Component {
    render(){
        return (
            <TableView style={{flex:1}}
                       allowsToggle={true}
                       allowsMultipleSelection={true}
                       tableViewStyle={TableView.Consts.Style.Grouped}
                       tableViewCellStyle={TableView.Consts.CellStyle.Subtitle}
                       onPress={(event) => console.log(event)}>
                <Section label="Section 1" arrow={true}>
                    <Item value="1" detail="Detail1" >Item 1</Item>
                    <Item value="2">Item 2</Item>
                </Section>
                <Section label="Section 2" arrow={false}>
                    <Item selected={true}>Item 1</Item>
                    <Item>Item 2</Item>
                    <Item>Item 3</Item>
                </Section>
            </TableView>
        );
    }
}

AppRegistry.registerComponent('AwesomeProject', () => AwesomeProject);

But table is without borders:

react-native-tableview version is 1.4.3

@yarax
Copy link
Author

yarax commented Jan 14, 2016

Also I can't do it manually, because according to this thread facebook/react-native#29 react-native doesn't support one-side borders, except of View component.

@yarax
Copy link
Author

yarax commented Jan 14, 2016

Now I see, that it depends on tableViewCellStyle, sorry, maybe it will be useful for someone else

@joegoodall1
Copy link

Any solution to this? Having the same problem that horizontal borders disappear on smaller devices eg. iPhone 5.

@joegoodall1
Copy link

Hi @yarax ,

How did you resolve this problem.

You mentioned tableViewCellStyle. What did you set that as?

@iRoachie
Copy link
Collaborator

iRoachie commented Dec 4, 2017

Hey new maintainer here. Closing out all* issues from before 2017. If this is still a concern, please create a new issue. Thanks

@iRoachie iRoachie closed this as completed Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants