Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot pass params to screens on navigate #3005

Closed
FrenchMajesty opened this issue Apr 21, 2018 · 6 comments
Closed

Cannot pass params to screens on navigate #3005

FrenchMajesty opened this issue Apr 21, 2018 · 6 comments

Comments

@FrenchMajesty
Copy link

FrenchMajesty commented Apr 21, 2018 •
edited
Loading

Version

Tell us which versions you are using:

  • react-native-router-flux v4.0.0-beta.28 (v3 is not supported)
  • react-native v0.52.0

Expected behaviour

For the app to navigate to the new screen with the params as props.

Actual behaviour

Error code undefined is not a function (evaluating '_this2[type](routeName, res)')

image

Steps to reproduce

The code for my router looks like this:

<Scene
	key="Filters"
	component={Filters}
	hideNavBar
/>

<Scene
	key="FiltersList"
	component={FiltersList}
	hideNavBar
/>

In my Filters screen, I want to navigate to the FiltersList and pass props but I get the error code I mentioned.

This is what my action looks like:

<ListItem
 	icon
 	button={true}
 	onPress={() => Actions.FiltersList({type: 'controller'})}
/>
 	<Body>
		<Text>Controllers</Text>
	</Body>
 	<Right>
 		<Icon name="ios-arrow-forward" />
 	</Right>
</ListItem>

Whenever I remove the params, then the app navigates to FiltersList without a problem but if I try to add the params I need then my app crash.

Any solutions around this problem?
@FrenchMajesty
Copy link
Author

If anybody had this issue, please use the react-navigation API that is provided in this package.

I wasn't really sure about what the documentation meant when it mentions the API... I guess for people familiar with the package there wouldn't be any need to mention it but the react-navigation API is accessible from Actions object.

Something along the lines of:

import { Actions } from 'react-native-router-flux';

Actions.push('FiltersList', {type: 'controller'});

@Blapi
Copy link
Collaborator

Blapi commented Apr 23, 2018

It is because type is a prop already used in this library (i.e. reset, refresh etc..), this is why it was not working.

A quick look at the API would have helped you.

@kholiavko-roman
Copy link

I try to change title using Actions.push, but prams didn't apply.

 Actions.push('settings', {
    title: Strings.interface.settings.title,
});

@d7laungani
Copy link

Same @kholiavko-roman did you end up finding a solution?

@kholiavko-roman
Copy link

@d7laungani, I did like this:
Actions.settings({ title: 'settings title' });
And when defined all routes of the app, you need set some default value for this params:
<Scene title='my page' />

@arthedza
Copy link

It is because type is a prop already used in this library (i.e. reset, refresh etc..), this is why it was not working.

A quick look at the API would have helped you.

I confirm this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Blapi @d7laungani @arthedza @kholiavko-roman @FrenchMajesty