Maximum call stack exceeded when closing drawer

[bsiddiqui]

Version

Tell us which versions you are using:

• react-native-router-flux v4.0.0-beta.22
• react-native v0.49.3

Issue

Whenever I close an open drawer I get this error

Possible Unhandled Promise Rejection (id: 2):
RangeError: Maximum call stack size exceeded
RangeError: Maximum call stack size exceeded
    at extendObservableHelper (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66411:32)
    at extendObservable (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66402:12)
    at Function.IObservableFactories.object (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66491:9)
    at deepEnhancer (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66567:45)
    at new ObservableValue (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:65571:23)
    at defineObservableProperty (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66269:45)
    at defineObservablePropertyFromDescriptor (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66251:13)
    at extendObservableHelper (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66429:17)
    at extendObservable (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66402:12)
    at Function.IObservableFactories.object (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66491:9)
    at deepEnhancer (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66567:45)
    at new ObservableValue (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:65571:23)
    at defineObservableProperty (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66269:45)
    at defineObservablePropertyFromDescriptor (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66251:13)
    at extendObservableHelper (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66429:17)
    at extendObservable (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66402:12)
    at Function.IObservableFactories.object (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66491:9)
    at deepEnhancer (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66567:45)
    at new ObservableValue (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:65571:23)
    at defineObservableProperty (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66269:45)
    at defineObservablePropertyFromDescriptor (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66251:13)
    at extendObservableHelper (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66429:17)
    at extendObservable (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66402:12)
    at Function.IObservableFactories.object (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66491:9)
    at deepEnhancer (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66567:45)
    at new ObservableValue (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:65571:23)
    at defineObservableProperty (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66269:45)
    at defineObservablePropertyFromDescriptor (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66251:13)
    at extendObservableHelper (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66429:17)
    at extendObservable (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66402:12)
    at Function.IObservableFactories.object (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66491:9)
    at deepEnhancer (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66567:45)
    at new ObservableValue (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:65571:23)
    at defineObservableProperty (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66269:45)
    at defineObservablePropertyFromDescriptor (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66251:13)
    at extendObservableHelper (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66429:17)
    at extendObservable (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66402:12)
    at Function.IObservableFactories.object (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66491:9)
    at deepEnhancer (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66567:45)
    at new ObservableValue (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:65571:23)
    at defineObservableProperty (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66269:45)
    at defineObservablePropertyFromDescriptor (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66251:13)
    at extendObservableHelper (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66429:17)
    at extendObservable (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66402:12)
    at Function.IObservableFactories.object (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66491:9)
    at deepEnhancer (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66567:45)
    at new ObservableValue (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:65571:23)
    at defineObservableProperty (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66269:45)
    at defineObservablePropertyFromDescriptor (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66251:13)
    at extendObservableHelper (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:66429:17)

[daviscabral]

Could you show some code from your router? Or put it in the Example folder to reproduce it?

[bsiddiqui]

@daviscabral here's some sample code from my router. Everything seems to function correctly but I see the warning whenever the drawer is closed and I return to the view that opened the drawer.

  <Router>
    <Stack key="root">
      <Scene initial key='launch' type='reset' component={LaunchImageContainer} />
      <Drawer hideNavBar
              key='drawer'
              drawerIcon={<MenuButton />}
              contentComponent={DrawerContainer} >
            <Scene
                title='Settings'
                key='usersSettings'
                component={UsersSettingsContainer} />

            <Scene
                title='Promotions'
                key='promotions'
                component={PromotionsContainer} />
      </Drawer>
    </Stack>
  </Router>

[daviscabral]

@bsiddiqui why the drawer parent is a Scene and not a Stack? Do you have more than one drawer?

[bsiddiqui]

@daviscabral the Drawer parent is a Stack - I just had the indentation wrong

[daviscabral]

Sorry - my bad.

[daviscabral]

Could you check if inside the DrawerContainer is there any reference to the Drawer component?

[bsiddiqui]

@daviscabral there's a reference to Actions but not Drawer

[daviscabral]

Which actions do you trigger over there? Do you have any calls in the willMount/unMount lifecycle methods?

[wluxion]

Running into this as well -- started happening when I added a renderLeftButton to a nested Stack (even if I only do this: <Stack key="abc" renderLeftButton={<View />} ...>).

UPDATE: Changing to <Stack key="abc" renderLeftButton={() => <View />} ...> fixed this -- perhaps the same for drawerIcon above?

[daviscabral]

Thanks for the update @wluxion.

@bsiddiqui can you confirm that this fixes your issue?

      <Drawer hideNavBar
              key='drawer'
              drawerIcon={() => <MenuButton />}
              contentComponent={DrawerContainer} >
      </Drawer>

[bsiddiqui]

@wluxion thanks yeah passing all components (contentComponent, renderLeftButton, renderTitle, etc) as fat arrow functions fixed the issue