Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scene's key on the background of TabIcon #2264

Closed
ShiiRochi opened this issue Aug 18, 2017 · 3 comments
Closed

Scene's key on the background of TabIcon #2264

ShiiRochi opened this issue Aug 18, 2017 · 3 comments

Comments

@ShiiRochi
Copy link

ShiiRochi commented Aug 18, 2017

Version

  • react-native-router-flux v4.0.0-beta.18
  • react-native v0.46.1

Expected behaviour

Expected to see tabbar with and Icon and Text below it with the possibility of tapping on it, so the selected will be highlighted

Actual behaviour

Actually see Tabbar with an Icon and Text below it with Scene's keyname on the background of Tabbar item with the possibility of tapping on it, but instead of TabIcon, Scene's keyname is highlighted

Steps to reproduce

I faced the problem with this code:
<Router sceneStyle={{ backgroundColor: 'white' }}> <Scene key="root" hideNavBar> <Scene key="Tabbar" hideNavBar tabs default='Main' tabBarStyle={{height:50}}> <Scene hideNavBar key="Main" component={MainSceneContainer} icon={TabIcon} iconName="user" title="Main page"/> </Scene> </Scene> </Router>
There is a picture, so you can understand what it mean:
voaupi0zusa

@ShiiRochi
Copy link
Author

ShiiRochi commented Aug 18, 2017

UPD:
Downgraded to version 3.41.0 and the code is working, so the issue persisting in version 4.0.0-beta.18

@aksonov
Copy link
Owner

aksonov commented Aug 21, 2017

Tabbar is big breaking change for v4 unfortunately. Try to disable labels like shown in Example project: showLabel={false} for tabs container.

@ShiiRochi
Copy link
Author

It helped, thanks

@aksonov aksonov closed this as completed Aug 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants