fix: escape image filenames (withastro#12697)

akshit20421 · Dec 9, 2024 · 1c4a032 · 1c4a032
1 parent 163cfd6
commit 1c4a032
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 1 deletion.
diff --git a/.changeset/famous-teachers-hug.md b/.changeset/famous-teachers-hug.md
@@ -0,0 +1,5 @@
+---
+'astro': patch
+---
+
+Fix a bug that caused builds to fail if an image had a quote mark in its name
diff --git a/packages/astro/src/content/mutable-data-store.ts b/packages/astro/src/content/mutable-data-store.ts
@@ -102,7 +102,7 @@ export class MutableDataStore extends ImmutableDataStore {
 		const exports: Array<string> = [];
 		this.#assetImports.forEach((id) => {
 			const symbol = importIdToSymbolName(id);
-			imports.push(`import ${symbol} from '${id}';`);
+			imports.push(`import ${symbol} from ${JSON.stringify(id)};`);
 			exports.push(`[${JSON.stringify(id)}, ${symbol}]`);
 		});
 		const code = /* js */ `

diff --git a/packages/astro/test/fixtures/content-layer/images/I'm back.jpg b/packages/astro/test/fixtures/content-layer/images/I'm back.jpg
diff --git a/packages/astro/test/fixtures/content-layer/src/content/space/endeavour.md b/packages/astro/test/fixtures/content-layer/src/content/space/endeavour.md
@@ -3,6 +3,8 @@ title: Endeavour
 description: 'Learn about the Endeavour NASA space shuttle.'
 publishedDate: 'Sun Jul 11 2021 00:00:00 GMT-0400 (Eastern Daylight Time)'
 tags: [space, 90s]
+heroImage: "@images/I'm back.jpg"
+
 ---
 
 **Source:** [Wikipedia](https://en.wikipedia.org/wiki/Space_Shuttle_Endeavour)