Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Bootstrap 4 #30

Open
coliff opened this issue Dec 11, 2018 · 3 comments
Open

Update to Bootstrap 4 #30

coliff opened this issue Dec 11, 2018 · 3 comments

Comments

@coliff
Copy link
Contributor

coliff commented Dec 11, 2018

It'd be a bit of work, but it'd be great to update this theme to use Bootstrap 4.

@aksakalli
Copy link
Owner

Hi coliff,

Thank you for your contribution and your suggestion.

The Bootswatch Project also supports Bootstrap 4. It is definitely doable. I wonder the advantages over Bootstrap 3. Should I maintain both versions or better switch to Bootstrap 4 for all. If you want to create a PR, I would really appreciate your help.

@coliff
Copy link
Contributor Author

coliff commented Dec 12, 2018

Hi @aksakalli - Bootstrap 4 is a big improvement in many ways, it works better across smaller screen sizes due to the extra viewport media query breakpoint. I don't think it's worth maintaining a separate version of the theme for Bootstrap 3.

I'm considering using this theme for a project and if I do, I'd like to update it to Bootstrap 4, in which case of course I'll open a PR. Thanks for the work you've done on this theme so far. :-)

@spk2dc
Copy link

spk2dc commented Aug 9, 2020

Was this ever accomplished? I'm new to jekyll and trying to use this theme but haven't been able to successfully update it to Bootstrap 4 which I will need for some of the features I want to add to my site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants