Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ak reliable #72

Open
bealdav opened this issue Apr 16, 2020 · 7 comments
Open

Make ak reliable #72

bealdav opened this issue Apr 16, 2020 · 7 comments
Assignees

Comments

@bealdav
Copy link
Member

bealdav commented Apr 16, 2020

It's difficult to update ak without the risk to break things

Actions that can be done:

  • complete tests
  • use .toml as spec file format because it's reduce the number of uses cases to test. Also Toml is more convenient for humans than yaml
  • move could be done gradually

Then yaml is ok for repo.yaml and frozen.yaml (generated by machines)

biblio

@bealdav bealdav assigned rvalyi, hparfr and sebastienbeau and unassigned rvalyi and hparfr Apr 16, 2020
@rvalyi
Copy link
Member

rvalyi commented Apr 17, 2020

For the tests, could we just take a the spec.yaml of a dozen of our Akretion projects as a test input and test here that the output repos.yaml is always the one we have?
Would it be enough to make it significantly stronger?
What would be the other outputs to test?

@rvalyi
Copy link
Member

rvalyi commented Apr 17, 2020

as for toml, I agree, however I fail to see where our current format would be so annoying for humans. I think edition and reading is pretty straightforward, Is that about the error reporting? In that case I agree that error reporting sucks currently. Eventually if the such a migration were decided then it would be about adding a new parser and generating the same python internal representation and the same output, a gradual migration as you said. I'm not sure about the cost/benefit of such a move and how error reporting could be improved or not.

@sebastienbeau
Copy link
Member

Hum on my side I do not know if it's a good idea to move to toml.

On my side I never had particular issue with the current yaml file. I am not saying that toml is not better, I am just saying that I didn't have any particular issue.

Moreover one thing that we should keep in mind is that in some complexe case we reuse the gitaggregate syntax for merging. Moving to toml will implies to have a differente syntax then gitaggregate for that case, so more stuff to learn

@bealdav
Copy link
Member Author

bealdav commented Apr 17, 2020

Yes Seb,

But because of https://www.python.org/dev/peps/pep-0518 we have to learn toml. We're not the guys in their old habits with setup.* in their libraries. Our packages should be up to date.

@hparfr
Copy link
Member

hparfr commented Apr 17, 2020

If you want to implement pep0518 go ahead. But keep it mind this pep is only about the build dependency definition.

@florian-dacosta
Copy link
Member

On my side, i agree with seb, it would be a shame to have a different format from gitaggregator...
It is not so rare when we have to reuse the gitaggregator syntax, on my side, it is even quite common.

We should move to Toml when gitaggregator will move to Toml
(speaking only about the spec.yml file of course)

@bealdav
Copy link
Member Author

bealdav commented Apr 17, 2020

The purpose of this PR is "make ak reliable", toml is an hypothesis to achieve it. Please focus to the main target and which forces we can put on it. Thanks ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants