-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ak reliable #72
Comments
For the tests, could we just take a the spec.yaml of a dozen of our Akretion projects as a test input and test here that the output repos.yaml is always the one we have? |
as for toml, I agree, however I fail to see where our current format would be so annoying for humans. I think edition and reading is pretty straightforward, Is that about the error reporting? In that case I agree that error reporting sucks currently. Eventually if the such a migration were decided then it would be about adding a new parser and generating the same python internal representation and the same output, a gradual migration as you said. I'm not sure about the cost/benefit of such a move and how error reporting could be improved or not. |
Hum on my side I do not know if it's a good idea to move to toml. On my side I never had particular issue with the current yaml file. I am not saying that toml is not better, I am just saying that I didn't have any particular issue. Moreover one thing that we should keep in mind is that in some complexe case we reuse the gitaggregate syntax for merging. Moving to toml will implies to have a differente syntax then gitaggregate for that case, so more stuff to learn |
Yes Seb, But because of https://www.python.org/dev/peps/pep-0518 we have to learn toml. We're not the guys in their old habits with setup.* in their libraries. Our packages should be up to date. |
If you want to implement pep0518 go ahead. But keep it mind this pep is only about the build dependency definition. |
On my side, i agree with seb, it would be a shame to have a different format from gitaggregator... We should move to Toml when gitaggregator will move to Toml |
The purpose of this PR is "make ak reliable", toml is an hypothesis to achieve it. Please focus to the main target and which forces we can put on it. Thanks ;-) |
It's difficult to update ak without the risk to break things
Actions that can be done:
Then yaml is ok for repo.yaml and frozen.yaml (generated by machines)
biblio
The text was updated successfully, but these errors were encountered: