Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSX support #19

Closed
kalliste opened this issue Oct 7, 2016 · 10 comments
Closed

OSX support #19

kalliste opened this issue Oct 7, 2016 · 10 comments

Comments

@kalliste
Copy link

kalliste commented Oct 7, 2016

Right now the plugin supports iOS apps only, but Cordova and Swift are also available for OSX

@akofman
Copy link
Owner

akofman commented Oct 14, 2016

Did you have a try with this plugin in an OSX context ? What issues do you encounter ?
I'm not really comfortable with the OSX version of Cordova, I'll use Electron in that case.

@kalliste
Copy link
Author

It wasn't immediately obvious how I would need to update the plugin code to get it going under OSX so I haven't tried it yet. I was looking at using it because I am wrapping a (proprietary) library in a cordova plugin and the library works on OSX so it would be convenient to test the plugin code this way.

@jab
Copy link

jab commented Jun 29, 2017

Interested in the same, and just found this issue. Did either of you ever get a chance to look at this since the most recent comment ~8 months ago? Happy to try to help too (though we're using the https://github.com/bitjson/cordova-plugin-swift-support fork only because that's the one that cordova-plugin-qrscanner depends on, no idea why they're apparently preferring to leave their fork divergent rather than attempting to merge upstream? /cc @bitjson -- any interest in merging back here, or explaining in your README the purpose of continuing to maintain a divergent fork? Thanks:)

@bitjson
Copy link

bitjson commented Jun 29, 2017

Hey @jab – info in this thread: #24

TL;DR:
probably use this one, not my fork
(but my fork will stay as-is for https://github.com/bitpay/cordova-plugin-qrscanner)

@jab
Copy link

jab commented Jun 29, 2017

@bitjson That link to #24 is really helpful, thanks! (Just sent you a PR to add that info to your README so others can find it more easily in the future.)

We'll probably stick to using your fork, since we already depend on cordova-plugin-qrscanner, and it seems better to not depend on both swift-support plugins as long as we can avoid it.

While we're here, do you have any interest in adding OS X support to your fork? (I'd ask that by opening a new issue for it in your repo, but it looks like issues are disabled there. Any interest in going into https://github.com/bitjson/cordova-plugin-swift-support/settings and enabling issues?)

Thanks again!

@jab
Copy link

jab commented Jul 21, 2017

Just wanted to try pinging you again @bitjson and @akofman - would love to know each of your interest in collaborating on adding OS X support (even if only to merge a patch), thanks!

@akofman
Copy link
Owner

akofman commented Dec 22, 2017

Hey,

I close this issue because I think #37 responded to your needs.

@akofman akofman closed this as completed Dec 22, 2017
@kalliste
Copy link
Author

#37 did not fix it but I just submitted a pull request that does

@kalliste
Copy link
Author

Pull request is #46

@kalliste
Copy link
Author

The resulting project doesn't build :/ but this gets us closer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants