Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes are made only to the current configuration (tipically Debug) #12

Closed
bugnano opened this issue Sep 1, 2016 · 1 comment
Closed

Comments

@bugnano
Copy link
Contributor

bugnano commented Sep 1, 2016

I'm using this plugin in order to build a plugin I wrote ( https://bitbucket.org/bugnano/cordova-plugin-networking-multipeer ).

EMBEDDED_CONTENT_CONTAINS_SWIFT is set to YES and LD_RUNPATH_SEARCH_PATHS is set to "@executable_path/Frameworks" only for the Debug configuration.

The problem is that when trying to submit the app to the App Store, it has to be compiled in the Release configuration, and those 2 settings have to be changed manually, as this plugin does not set them correctly (otherwise the app will crash on startup).

I propose to change the settings in all the possible configurations, not just for the current one.

@akofman
Copy link
Owner

akofman commented Sep 1, 2016

Hello,

I didn't have time to reproduce this issue but it seems to be related to this PR : #11, could you check it and let me know if it's fine with this fixe ?

@akofman akofman closed this as completed Sep 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants