Akka.Cluster SplitBrainResolver: don't down oldest if alone in cluster #3690
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Lightbend docs for the split brain resolver, it mentions (emphasis mine):
I noticed that this bit didn't seem to be included in the corresponding Akka.NET docs for the resolver. Was it an intentional choice not to implement that aspect of it?
I've included a test and a possible tweak to the logic to account for not downing the oldest node if it's alone in the cluster. I've been staring at this for too long tonight and will take another pass in the morning, but wanted to throw this up in the meantime for conversation and to see if I was missing something here in how all this should work.