Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Akka.Cluster SplitBrainResolver: don't down oldest if alone in cluster #3690

Merged
merged 1 commit into from
Dec 31, 2018

Conversation

gshackles
Copy link
Contributor

In the Lightbend docs for the split brain resolver, it mentions (emphasis mine):

There is one exception to this rule if down-if-alone is configured to on. Then, if the oldest node has partitioned from all other nodes the oldest will down itself and keep all other nodes running. The strategy will not down the single oldest node when it is the only remaining node in the cluster.

I noticed that this bit didn't seem to be included in the corresponding Akka.NET docs for the resolver. Was it an intentional choice not to implement that aspect of it?

I've included a test and a possible tweak to the logic to account for not downing the oldest node if it's alone in the cluster. I've been staring at this for too long tonight and will take another pass in the morning, but wanted to throw this up in the meantime for conversation and to see if I was missing something here in how all this should work.

@Horusiath Horusiath self-requested a review December 29, 2018 14:55
@Aaronontheweb Aaronontheweb added this to the 1.3.12 milestone Dec 31, 2018
@Aaronontheweb Aaronontheweb merged commit 64f41a2 into akkadotnet:dev Dec 31, 2018
@gshackles gshackles deleted the splitbrain-oldest-fix branch January 1, 2019 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants