Fixed ReceiveTimeout not triggered in some case when combined with NotInfluenceReceiveTimeout messages #3555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ismaelhamed
commented
Jul 22, 2018
| @@ -47,7 +47,7 @@ public void SetReceiveTimeout(TimeSpan? timeout=null) | |||
| public void CheckReceiveTimeout() | |||
| { | |||
| CancelReceiveTimeout(); | |||
| if (_receiveTimeoutDuration != null && !Mailbox.HasMessages) | |||
| if (_receiveTimeoutDuration != null) | |||
There was a problem hiding this comment.
There were some performance concerns about this re-scheduling always now, but the PR was approved anyway.
There was a problem hiding this comment.
I agree that this is the most straight forward way to implement it. I'm somewhat concerned about the performance implication of always rescheduling, but other solutions I can think of are too complicated and have other drawbacks.
I agree with what Patrik said.
Aaronontheweb
approved these changes
Jul 23, 2018
cuteant
pushed a commit
to cuteant/akka.net
that referenced
this pull request
Jul 29, 2018
…tnet#3553) take from akkadotnet@a19051a * sharding log formatting fix (akkadotnet#3554) take from akkadotnet@f406bfd * Fix ReceiveTimeout issue with NotInfluenceReceiveTimeout (akkadotnet#3555) take from akkadotnet@d1c1efe
This was referenced Aug 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port #24927