Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeTestRunner should report inner exceptions for all exception types #4162

Closed
IgorFedchenko opened this issue Jan 24, 2020 · 0 comments · Fixed by #4163
Closed

NodeTestRunner should report inner exceptions for all exception types #4162

IgorFedchenko opened this issue Jan 24, 2020 · 0 comments · Fixed by #4163

Comments

@IgorFedchenko
Copy link
Contributor

Having this line in MNTR logs:

[Node #1(node-1)][ERROR][1/23/2020 8:51:21 PM][Thread 0018][akka://ClusterMetricsEnabledSpec/system/log2-TestEventListener] The type initializer for 'Akka.Cluster.Metrics.Serialization.ClusterMetricsMessagesReflection' threw an exception.

This looks like a Message property of TypeInitializationException class - and usually the real issue is stored in InnerException property (or it's InnerException, or even deeper - but you got the idea).

Currently, NodeTestRunner is catching AggregateException and adding it's inner exceptions to failure report (logging them as well) - but for general Exception type only wrapping exception is logged, which is not enough in some cases (like above).

So need to report all inner exceptions of any thrown exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants