Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CurrentEventsByTag does not return more than a 100 events #3697

Closed
ptjhuang opened this issue Jan 17, 2019 · 4 comments
Closed

CurrentEventsByTag does not return more than a 100 events #3697

ptjhuang opened this issue Jan 17, 2019 · 4 comments

Comments

@ptjhuang
Copy link
Contributor

ptjhuang commented Jan 17, 2019

Akka.Net 1.3.11
.NET Core Windows
Call SqlReadJournal.CurrentEventsByTag with empty an event log throws ArgumentException: To offset must be a positive number

Test Case: https://gist.github.com/ptjhuang/fc44fa9ca80e87fe7835f71e06aa40da

Looked at the Scala version and it looks different. Is this a bug?

Scala version

.NET version

@ptjhuang ptjhuang changed the title CurrentEventsByTag throws error when event log is empty CurrentEventsByTag does not return more than a 100 events Jan 17, 2019
@ismaelhamed
Copy link
Member

ismaelhamed commented Jan 19, 2019

LIMIT for CurrentEventsByTag is controlled by the query.journal.sql.max-buffer-size option --which is 100 by default. See line #85.

Any differences with the JVM might be worth looking at, in case they made any improvements.

cc @Horusiath @Aaronontheweb

@Horusiath
Copy link
Contributor

CurrentEventsByTag should return all events, then complete the stream, once it reached the end. MaxBufferSize only describes the size of the batched, in which we internally poll for the data from the database.

@ismaelhamed
Copy link
Member

ismaelhamed commented Jan 20, 2019

In the current implementation CurrentEventsByTag polls the database only once, hence why the query.journal.sql.max-buffer-size acts as a limit here. Potential bug then?

@Aaronontheweb
Copy link
Member

close via #3698

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants