Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tcp-reuse-addr = off-for-windows prevents actorsystem from starting #3293

Closed
nvivo opened this issue Jan 24, 2018 · 3 comments · Fixed by #3674
Closed

tcp-reuse-addr = off-for-windows prevents actorsystem from starting #3293

nvivo opened this issue Jan 24, 2018 · 3 comments · Fixed by #3674
Milestone
1.3.11

Comments

@nvivo
Copy link
Contributor

nvivo commented Jan 24, 2018

Remote.conf states off-for-windows as one of the possible values for tcp-reuse-addr, but 1.3.3 fails to start when used:

 System.NotSupportedException: Unknown boolean format: off-for-windows
   at Akka.Configuration.Hocon.HoconValue.GetBoolean()
   at Akka.Remote.Transport.DotNetty.DotNettyTransportSettings.Create(Config config)
   at Akka.Remote.Transport.DotNetty.DotNettyTransport..ctor(ActorSystem system, Config config)
@Horusiath
Copy link
Contributor

@nvivo error message suggests that configuration value for off-for-windows is not a valid HOCON boolean.

@maxcherednik
Copy link
Contributor

#2477

@nvivo
Copy link
Contributor Author

nvivo commented Jan 24, 2018

@Horusiath Yes, I saw that. I'm currently setting this up manually during my hocon generation. The point is that from the documentation, this shouldn't be parsed as boolean. I'm guessing this worked with helios, but but was lost during the transition to dotnetty.

@Aaronontheweb Aaronontheweb added this to the 1.3.5 milestone Feb 1, 2018
@marcpiechura marcpiechura modified the milestones: 1.3.5, 1.3.6 Mar 5, 2018
@Aaronontheweb Aaronontheweb modified the milestones: 1.3.6, 1.3.7 Apr 19, 2018
@Aaronontheweb Aaronontheweb modified the milestones: 1.3.7, 1.3.8 May 15, 2018
@marcpiechura marcpiechura modified the milestones: 1.3.8, 1.3.9 Jun 5, 2018
@Aaronontheweb Aaronontheweb modified the milestones: 1.3.9, 1.3.10 Sep 5, 2018
@Aaronontheweb Aaronontheweb modified the milestones: 1.3.10, 1.3.11 Dec 14, 2018
Aaronontheweb added a commit to Aaronontheweb/akka.net that referenced this issue Dec 14, 2018
@Aaronontheweb
close akkadotnet#3293 close akkadotnet#2477 - changed dot-netty.tcp.r…
4ed09e6 
…euse-addr to default to 'off-for-windows'
@Aaronontheweb Aaronontheweb mentioned this issue Dec 14, 2018
Merged
Aaronontheweb added a commit that referenced this issue Dec 18, 2018
@Aaronontheweb
Changed dot-netty.tcp.reuse-addr to default to 'off-for-windows' (#3674)
48e9d22 
* close #3293 close #2477 - changed dot-netty.tcp.reuse-addr to default to 'off-for-windows'

* changed the default config setting to 'off-for-windows'

* Fixed RemoteConfigSpec
This was referenced Dec 18, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.11
Development

Successfully merging a pull request may close this issue.

Changed dot-netty.tcp.reuse-addr to default to 'off-for-windows' Aaronontheweb/akka.net
5 participants
@nvivo @Aaronontheweb @Horusiath @maxcherednik @marcpiechura