Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NetCore support for FSharp projects #2826

Closed
alexvaluyskiy opened this issue Jul 4, 2017 · 17 comments
Closed

Add NetCore support for FSharp projects #2826

alexvaluyskiy opened this issue Jul 4, 2017 · 17 comments

Comments

@alexvaluyskiy
Copy link
Contributor

F# was not updated for NetCore, because we have two problems
FSharp.Community.Linq does not support NetCore
FSharp.Quotations.Evaluator which could do the same does not support NetCore as well

Also Akka.FSharp.Tests does not compile at all

@tjaskula @Horusiath

@Horusiath
Copy link
Contributor

Horusiath commented Jul 5, 2017

It looks like we may need another quotation expression evaluator. There are few others with various degree of speed:

  1. Unquote which is more useful in tests.
  2. QuotationCompiler which is pretty great, but as far as I know, it brings whole FCS as a depdendency.

@tjaskula anything, you'd add here? Ofc we could also roll our own if no other option will be valid.

@alexvaluyskiy
Copy link
Contributor Author

@Horusiath Both of them without NetStandard support.
FSharp.Quotations.Evaluator supports PCL, so it would be easy to convert it to NetStandard

@tjaskula
Copy link
Contributor

tjaskula commented Jul 6, 2017

@Horusiath Yeah, I think for now FSharp.Quotations.Evaluator would be the easiest one to convert.
Rolling our own I would consider as last ressort.
I'm on this issue, you can assign it to me. I keep you posted.

@tjaskula
Copy link
Contributor

tjaskula commented Jul 6, 2017

FYI, I'll be converting to .NET Core FSharp.Quotations.Evaluator.

@alexvaluyskiy
Copy link
Contributor Author

Just to track it fsprojects/FSharp.Quotations.Evaluator#15

@Aaronontheweb
Copy link
Member

@heynickc has been working on this here and it's a bit of a tire fire: #2941

Looks like FSharp.Quotations.Evaluator hasn't merged @tjaskula's PR yet, which is a bummer. We'll have to do a separate release to get .NET Standard support for the F# API at a later date (1.3.1)

@jichang
Copy link

jichang commented Feb 19, 2018

any progress on this ?

@tjaskula
Copy link
Contributor

FSharp.Quotations.Evaluator had some issues compiling with .NET Core. I'll have to check it out again and I'll keep you posted.

@marcpiechura marcpiechura modified the milestones: 1.3.3, 1.4.0 Mar 5, 2018
@ivog
Copy link
Contributor

ivog commented Mar 20, 2018

@tjaskula I’ve created a pull request for FSharp.Quotations.Evaluator which solve the compile issues. Hopefully it can be merged soon!

@ivog
Copy link
Contributor

ivog commented Mar 21, 2018

FSharp.Quotations.Evaluator has a new nuget package targetting netstandard2.0 now

@kennethito
Copy link
Contributor

Just found this. I did some similar work when I noticed the FSharp.Quotations.Evaluator release to see how feasible a netstandard fsharp release was. I'm currently running the tests from a netcoreapp2.0 only entrypoint and I think I might be seeing more issues.

My branch is here, feel free to take anything that's useful.
kennethito@dd122b7

I was additionally seeing the following problems

@ivog
Copy link
Contributor

ivog commented Apr 12, 2018

@tjaskula Now that #3369 is merged can this issue be closed and can a new Akka.FSharp release be created? Or are there more hurdles to overcome?

@tjaskula
Copy link
Contributor

Of course. However I'm not allowed to do anything but commenting.

@marcpiechura
Copy link
Contributor

We‘re planning to release 1.3.6 shortly, so it should be available once it’s up on nuget.

CC @aarontheweb

@mariomeyrelles
Copy link

As a normal user, does this mean that we will have support for F# and .NET Core in this next release?

@marcpiechura marcpiechura modified the milestones: 1.4.0, 1.3.6 Apr 15, 2018
@marcpiechura
Copy link
Contributor

@mariomeyrelles yup

@j-alexander
Copy link

Akka.Persistence.FSharp was not included? Looks like it targets net45 only? Any recommendations for that one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants