-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NetCore support for FSharp projects #2826
Comments
It looks like we may need another quotation expression evaluator. There are few others with various degree of speed:
@tjaskula anything, you'd add here? Ofc we could also roll our own if no other option will be valid. |
@Horusiath Both of them without NetStandard support. |
@Horusiath Yeah, I think for now |
FYI, I'll be converting to .NET Core |
Just to track it fsprojects/FSharp.Quotations.Evaluator#15 |
any progress on this ? |
|
@tjaskula I’ve created a pull request for FSharp.Quotations.Evaluator which solve the compile issues. Hopefully it can be merged soon! |
FSharp.Quotations.Evaluator has a new nuget package targetting netstandard2.0 now |
Just found this. I did some similar work when I noticed the FSharp.Quotations.Evaluator release to see how feasible a netstandard fsharp release was. I'm currently running the tests from a netcoreapp2.0 only entrypoint and I think I might be seeing more issues. My branch is here, feel free to take anything that's useful. I was additionally seeing the following problems
|
Of course. However I'm not allowed to do anything but commenting. |
We‘re planning to release 1.3.6 shortly, so it should be available once it’s up on nuget. CC @aarontheweb |
As a normal user, does this mean that we will have support for F# and .NET Core in this next release? |
@mariomeyrelles yup |
Akka.Persistence.FSharp was not included? Looks like it targets net45 only? Any recommendations for that one? |
F# was not updated for NetCore, because we have two problems
FSharp.Community.Linq does not support NetCore
FSharp.Quotations.Evaluator which could do the same does not support NetCore as well
Also Akka.FSharp.Tests does not compile at all
@tjaskula @Horusiath
The text was updated successfully, but these errors were encountered: