Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insecure deserialization #239

Closed
games opened this issue Jul 11, 2021 · 3 comments
Closed

Insecure deserialization #239

games opened this issue Jul 11, 2021 · 3 comments
Milestone

Comments

@games
Copy link

games commented Jul 11, 2021

Hi there, just want to know is that true?

Security advisories: GHSA-hpw7-3vq3-mmv6

Due to how Wire handles type information in its serialization format, malicious payloads can be passed to a deserializer. e.g. using a surrogate on the sender end, an attacker can pass information about a different type for the receiving end. And by doing so allowing the serializer to create any type on the deserializing end.
This is the same issue that exists for .NET BinaryFormatter https://docs.microsoft.com/en-us/visualstudio/code-quality/ca2300?view=vs-2019
This also applies to the fork of Wire, AkkaDotNet/Hyperion.

@Aaronontheweb
Copy link
Member

@games this applies to any form of polymorphic serialization - so yes that affects Hyperion. We have a PR here that I'm reviewing now that implements a solve for this: #242

@Aaronontheweb
Copy link
Member

Related: #226

@Aaronontheweb Aaronontheweb modified the milestones: v0.11, v0.12 Aug 16, 2021
@Aaronontheweb
Copy link
Member

Resolved via #242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants