Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigQuery: Fix the order of parameters for insertAll #2761

Merged
merged 1 commit into from
Oct 29, 2021
Merged

BigQuery: Fix the order of parameters for insertAll #2761

merged 1 commit into from
Oct 29, 2021

Conversation

balagez
Copy link
Contributor

@balagez balagez commented Oct 22, 2021 •
edited
Loading

Bugfix: The insertAll method that creates the Flow expects datasetId and tableId in this order but when calling it from the insertAll method that creates the Sink, the order of parameters is swapped so when using the Sink the request is sent to the wrong Google API URL.

ennru
ennru approved these changes Oct 29, 2021
View reviewed changes
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru ennru added this to the 3.0.4 milestone Oct 29, 2021
@ennru ennru changed the title Fix the order of parameters in BigQuery insertAll BigQuery: Fix the order of parameters for insertAll Oct 29, 2021
@ennru ennru merged commit ec17f87 into akka:master Oct 29, 2021
@ennru
Copy link
Member

ennru commented Oct 29, 2021

Thank you!

@balagez balagez deleted the bigquery-fix branch October 29, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ennru ennru ennru approved these changes

Assignees
No one assigned
Labels
p:google-cloud-bigquery
Projects
None yet
Milestone
3.0.4
Development

Successfully merging this pull request may close these issues.
2 participants
@balagez @ennru