Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AMQP: Revise API #1513

Closed
ennru opened this issue Feb 19, 2019 · 0 comments
Closed

AMQP: Revise API #1513

ennru opened this issue Feb 19, 2019 · 0 comments
Labels
p:amqp
Milestone
1.0-M3

Comments

@ennru
Copy link
Member

ennru commented Feb 19, 2019

The Alpakka AMQP API has a couple of issues which should be resolved going forward:

  1. Stream elements are called IncomingMessage and OutgoingMessage which does not make sense for the user (recommended are ReadResult, WriteMessage, WriteResult)

  2. committableFlow and the setting ackRequired are a bit conflated (see discussion in Don't ack when 'no ack required' #1167)

I'll mark the API with @ApiMayChange.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p:amqp
Projects
None yet
Milestone
1.0-M3
Development

No branches or pull requests
2 participants
@2m @ennru