Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testkit: fail better if cluster hasn't started #1492

Merged
merged 2 commits into from
May 1, 2022
Merged

testkit: fail better if cluster hasn't started #1492

merged 2 commits into from
May 1, 2022

Conversation

yuvalshi0
Copy link
Contributor

@yuvalshi0 yuvalshi0 commented Apr 9, 2022 •
edited
Loading

Closes #1491
*Not sure if it's the best solution

@yuvalshi0 yuvalshi0 marked this pull request as draft April 9, 2022 13:20
@yuvalshi0 yuvalshi0 marked this pull request as ready for review April 9, 2022 13:48
ennru
ennru approved these changes May 1, 2022
View reviewed changes
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru ennru changed the title Fixed calling methods which use cluster under the hood can cause NullPointerExecption testkit: fail better if cluster hasn't started May 1, 2022
@ennru ennru merged commit d4949e3 into akka:master May 1, 2022
@ennru
Copy link
Member

ennru commented May 1, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ennru ennru ennru approved these changes

Assignees
No one assigned
Labels
testkit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calling methods which use cluster under the hood can cause NullPointerExecption
2 participants
@yuvalshi0 @ennru