-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation and example for cluster formation with Istio #352
Comments
Perhaps (based on) https://github.com/jroper/akka-ddata-shopping-cart-knative? |
From my limited understanding of Itsio any of the tradeoffs for making it work with Akka Cluster are not suitable for production so should we really document one of them? Don't you have to remove health checks? |
I think you're right, @chbatey that we don't have a solid solution yet (particularly given #209 (comment)). Maybe we should explicitly recommend against using Istio until there is a better solution in place. IIUC the readiness probe would only have to be disabled for the service defining |
Documentation was written in #568. Given that the only difference between an Istio deployed app and a regular Kubernetes app is two annotations, I'm not sure that a full example is warranted. We could update one of the existing examples to have the Istio annotations, since they are benign if present when Istio is not in use, with a comment saying "these are necessary when using Istio, if not using Istio, they can be deleted." Though that might add unnecessary noise to the spec for the general case. |
I think the example in the documentation is sufficient for now. I'll close this issue now and work to get some customer feedback on the documentation. If we need to expand it, I'll raise new issues. |
This documentation is now published at https://doc.akka.io/docs/akka-management/current/bootstrap/istio.html |
It's not totally straightforward to configure clustering/cluster bootstrap when running Kubernetes with Istio installed. There are some tips in #209. It would be nice to make this advice more visible, with a complete recipe at https://developer.lightbend.com/docs/akka-management/current/bootstrap/recipes.html
The text was updated successfully, but these errors were encountered: