Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SyntheticHeader public #3349

Closed
chetanmeh opened this issue Jul 6, 2020 · 5 comments
Closed

Make SyntheticHeader public #3349

chetanmeh opened this issue Jul 6, 2020 · 5 comments
Milestone

Comments

@chetanmeh
Copy link
Contributor

In our project we need to log details related to request and response as part of access log. Such logs should also include the header details. While dumping all request header the logs also include the timeout-access header which is a synthetic header used internally by Akka HTTP.

Currently there is no easy way to distinguish which header is a user provided one and which one is generated by Akka HTTP. One way would be to make akka.http.scaladsl.model.headers.SyntheticHeader trait public. Then we can easily filter out such synthetic header via type check.

@raboof
Copy link
Member

raboof commented Jul 6, 2020

Hmm, I'm not sure we want to expose this, since we're (slowly) moving away from synthetic headers and using 'Attributes' instead.

Perhaps a compromise might be to remove the private modified but add an @InternalApi so you can 'peek' but we don't promise keeping it intact going forward?

@chetanmeh
Copy link
Contributor Author

Perhaps a compromise might be to remove the private modified but add an @internalapi so you can 'peek' but we don't promise keeping it intact going forward

+1. That would work for me in the interim

@chetanmeh
Copy link
Contributor Author

using 'Attributes' instead

Any reference to this Attribute support?

@raboof
Copy link
Member

raboof commented Jul 6, 2020

#1500 / https://doc.akka.io/docs/akka-http/snapshot/common/http-model.html#attributes

@jrudolph jrudolph added this to the duplicate milestone Jul 28, 2020
@jrudolph
Copy link
Member

Let's close this as attributes seem like the way forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants