Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make protobuf directories consistent #323

Closed
chbatey opened this issue Aug 7, 2018 · 4 comments
Closed

Make protobuf directories consistent #323

chbatey opened this issue Aug 7, 2018 · 4 comments
Assignees
Milestone

Comments

@chbatey
Copy link
Contributor

chbatey commented Aug 7, 2018

Ideally all build tools could pick up from proto (standard for java tooling) and protobuf (scalapb). If not make build tools consistent so SBT protobuf regardless of language and Gradle/Maven proto regardless of language and override defaults in sample projects so they work with all 3 build tools

@chbatey chbatey self-assigned this Aug 7, 2018
@chbatey chbatey added this to the 0.2 milestone Aug 7, 2018
@jrudolph
Copy link
Contributor

Is this now closed? And what was the final decision which directories to show by default? If we chose to use proto everywhere we might want to adapt it in the Scala documentation.

@ktoso
Copy link
Contributor

ktoso commented Aug 14, 2018

Suggestion was to:

  • support both - done
  • show docs consistent with what given build tool likes - not sure if done, please confirm @chbatey @raboof ?

@chbatey
Copy link
Contributor Author

chbatey commented Aug 15, 2018

We should do a check of the docs then close this.

@raboof
Copy link
Contributor

raboof commented Aug 15, 2018

checking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants