Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Names with brackets < and > get interpreted as HTML tag #49

Closed
EmilStenstrom opened this issue Jul 14, 2022 · 6 comments
Closed

Names with brackets < and > get interpreted as HTML tag #49

EmilStenstrom opened this issue Jul 14, 2022 · 6 comments

Comments

@EmilStenstrom
Copy link

Hi! I have a contributor with angle brackets like this: <USER NAME HERE>. This name shows up empty in the readme. I think it would be a good idea to escape the user name to avoid breaking the readme.

image

@akhilmhdh
Copy link
Owner

Good catch. Soon ill be applying a templating engine in v4.

But yah ill release a patch immediately

@akhilmhdh
Copy link
Owner

Hey @EmilStenstrom . I have released patch for this action. Contributors-Readme-Action v2.3.5.

Closing this issue as its resolved. Feel free to re-open if its not resolved.

@EmilStenstrom
Copy link
Author

Works great, thanks again @akhilmhdh! :)

@EmilStenstrom
Copy link
Author

Not so fast. It seems to re-escape the already escaped characters each time it's run. Check this PR: EmilStenstrom/django-components@8f76c3f

@akhilmhdh
Copy link
Owner

Ohhh dang @EmilStenstrom my bad. Will resolve it. I missed that case

@akhilmhdh akhilmhdh reopened this Jul 30, 2022
@akhilmhdh
Copy link
Owner

hey @EmilStenstrom released a patch v2.3.6 that fixed the re-encoding issue. Let me know if any issue with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants