Symfony 3.0 upgrade #3571
Closed
Symfony 3.0 upgrade #3571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Saša, we appreciate it very much ;) |
|
Wow, awesome work ! |
|
Hello Saša @umpirsky, Do you want to continue to work on this PR? If no, could you rebase it so that we merged it like that? |
umpirsky
force-pushed
the
feature/symfony3-upgrade
branch
from
d80a997
to
2869c24
Compare
umpirsky
force-pushed
the
feature/symfony3-upgrade
branch
from
2869c24
to
d60fb44
Compare
|
Hi @jjanvier! :) I just pushed an update, not much fixed now, just some form types. Let's wait for the build. 👍 |
|
hi @umpirsky, can you give feedback on that PR? Can we close it ? |
|
@Arn0d I rebased on |
|
@umpirsky I will close it for now. I will try Symfony-Upgrade-Fixer when we will bump Symfony to the version 3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am testing Symfony Upgrade Fixer against several Symfony projects.
Will continue pushing commits to this PR, I hope you will find them useful.