chore: automated PR to main 2024-06-30 #179
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -183,7 +183,7 @@ | |||
| insecureTransport.MaxIdleConnsPerHost = HTTPMaxIdleConnsPerHost | |||
| // #nosec G402 | |||
| insecureTransport.TLSClientConfig = &tls.Config{ | |||
| InsecureSkipVerify: true, | |||
| InsecureSkipVerify: true, //nolint:gosec | |||
Check failure
Code scanning / CodeQL
Disabled TLS certificate check High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 21 days ago
To fix the problem, we should avoid setting InsecureSkipVerify to true in production code. Instead, we should ensure that the application uses valid certificates and performs proper certificate verification. If there is a need to handle both secure and insecure connections, we should provide a configuration option that allows the user to specify whether to skip certificate verification, but default to secure connections.
In this specific case, we will remove the insecureTransport configuration and ensure that the application only uses the secureTransport configuration. This will enforce TLS certificate verification.
Suggested changeset
1
pkg/referrerstore/oras/oras.go
| @@ -179,14 +179,2 @@ | ||
|
|
||
| // define the http client for TLS disabled | ||
| insecureTransport := http.DefaultTransport.(*http.Transport).Clone() | ||
| insecureTransport.MaxIdleConns = HTTPMaxIdleConns | ||
| insecureTransport.MaxConnsPerHost = HTTPMaxConnsPerHost | ||
| insecureTransport.MaxIdleConnsPerHost = HTTPMaxIdleConnsPerHost | ||
| // #nosec G402 | ||
| insecureTransport.TLSClientConfig = &tls.Config{ | ||
| InsecureSkipVerify: true, //nolint:gosec | ||
| } | ||
| insecureRetryTransport := retry.NewTransport(insecureTransport) | ||
| insecureRetryTransport.Policy = customRetryPolicy | ||
|
|
||
| return &orasStore{config: &conf, | ||
| @@ -196,3 +184,2 @@ | ||
| httpClient: &http.Client{Transport: secureRetryTransport}, | ||
| httpClientInsecure: &http.Client{Transport: insecureRetryTransport}, | ||
| createRepository: createDefaultRepository}, nil |
Copilot is powered by AI and may make mistakes. Always verify output.
akashsinghal
temporarily deployed
to
azure-test
GitHub Actions
Inactive
…t#1963) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Akash Singhal <[email protected]>
…-project#1973) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
akashsinghal
had a problem deploying
to
azure-test
GitHub Actions
Failure
akashsinghal
had a problem deploying
to
azure-test
GitHub Actions
Failure
akashsinghal
had a problem deploying
to
azure-test
GitHub Actions
Failure
akashsinghal
had a problem deploying
to
azure-test
GitHub Actions
Failure
akashsinghal
had a problem deploying
to
azure-test
GitHub Actions
Failure
akashsinghal
had a problem deploying
to
azure-test
GitHub Actions
Failure
Signed-off-by: Akash Singhal <[email protected]>
…-project#1900) Signed-off-by: Juncheng Zhu <[email protected]> Co-authored-by: Binbin Li <[email protected]> Co-authored-by: Susan Shi <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ect#1971) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…t#1966) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
… to 1.2.0-rc.2 (ratify-project#1970) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…t#1978) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Akash Singhal <[email protected]>
Signed-off-by: Akash Singhal <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
akashsinghal
temporarily deployed
to
azure-test
GitHub Actions
Inactive
akashsinghal
temporarily deployed
to
azure-test
GitHub Actions
Inactive
akashsinghal
temporarily deployed
to
azure-test
GitHub Actions
Inactive
akashsinghal
temporarily deployed
to
azure-test
GitHub Actions
Inactive
akashsinghal
temporarily deployed
to
azure-test
GitHub Actions
Inactive
akashsinghal
temporarily deployed
to
azure-test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated Pull Request to main branch