Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[provider]: increase ManifestServiceExposeHTTPOptions.MaxBodySize from uint32 #156

Open
ishandhanani opened this issue Nov 29, 2023 · 0 comments
Assignees
Labels
needs-verification repo/akash-api repo/provider Akash provider-services repo issues

Comments

@ishandhanani
Copy link

Describe the bug

  • account address = akash1qymxrv5sk6xc4tv9ld9avf4gkq7wpuu5rtcajx
  • The relevant part of the deploy.yaml is
    expose:
      - port: 8888
        as: 80
        to:    
          - global: true
        http_options:
          max_body_size: 4294967294 #old value was 5368709120. new value is MAX_uint32 - 1 for safety

We are trying to increase the upload size to a Jupyter Notebook instance to around 5GB. However, due to the uint32 limit, we cannot increase past ~4GB.

To Reproduce
Steps to reproduce the behavior:
Create an SDL with the http_options shown above. The cloudmos proxy throws

Status code was not success (422) : json: cannot unmarshal number 5368709120 into Go struct field ServiceExposeHTTPOptions.services.expose.httpOptions.maxBodySize of type uint32

Expected behavior
This is expected as the limit is uint32

Potential fix
Increase that field to uint64. The relevant code is here. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-verification repo/akash-api repo/provider Akash provider-services repo issues
Projects
None yet
Development

No branches or pull requests

4 participants