Implement logger #102
Open
Implement logger #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes akash-network#71 Replaced all `console.log` and `console.error` statements with pino logger statements. * Imported pino and created a logger instance in `examples/create_deployment.ts`, `examples/details_of_single_provider.ts`, `examples/estimate_gas.ts`, `examples/get_deployments.ts`, `examples/get_lease_status.ts`, `examples/list_all_providers.ts`, `src/wallet/storage.ts`, `test.html`, and `tests/test_deployments.ts`. * Replaced all `console.log` statements with `logger.info` in the above files. * Replaced all `console.error` statements with `logger.error` in `examples/create_deployment.ts`.
|
Thanks for contributing to the repo! We'll take a look at your prs shortly. cc @ygrishajev |
baktun14
reviewed
Oct 31, 2024
| @@ -11,6 +12,8 @@ import { | |||
| QueryDeploymentsResponse | |||
| } from "@akashnetwork/akash-api/akash/deployment/v1beta3/query"; | |||
|
|
|||
| const logger = pino(); | |||
| @@ -12,7 +12,11 @@ | |||
| <button id="getCerts">Get Certs</button> | |||
|
|
|||
| <script type="text/javascript"> | |||
| console.log(akjs); | |||
| import pino from 'pino'; | |||
| @@ -12,6 +12,9 @@ import { SDL } from "@akashnetwork/akashjs/build/sdl"; | |||
| import { getAkashTypeRegistry } from "@akashnetwork/akashjs/build/stargate"; | |||
| import { CertificatePem } from "@akashnetwork/akashjs/build/certificates/certificate-manager/CertificateManager"; | |||
| import { certificateManager } from "@akashnetwork/akashjs/build/certificates/certificate-manager"; | |||
| import pino from "pino"; | |||
There was a problem hiding this comment.
Did you install pino? I don't see it in the package.json
There was a problem hiding this comment.
maybe I forgot to add package.json while pushing the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71
Replaced all
console.logandconsole.errorstatements with pino logger statements.examples/create_deployment.ts,examples/details_of_single_provider.ts,examples/estimate_gas.ts,examples/get_deployments.ts,examples/get_lease_status.ts,examples/list_all_providers.ts,src/wallet/storage.ts,test.html, andtests/test_deployments.ts.console.logstatements withlogger.infoin the above files.console.errorstatements withlogger.errorinexamples/create_deployment.ts.