feat(ts): adds connect-es generated code (#184) #157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be nice to have examples of how to use both grpc clients in the ts README |
Ok, but I’ll attempt to avoid this pr first as discussed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces necessary updates to support
connect-esin addition tots-protogenerated code which is needed for our indexer application. It includes the generation of provider code and updates to the package exports to includeconnect-esmodules. Additionally, the directory structure has been updated along with the dynamic exports generator script to reflect these changes.Key Changes
connect-es.connect-esexports, ensuring that all generated modules are correctly exposed for use in the application.make/codegen.mk: Updated commands forconnect-esgeneration alongside existingts-protogeneration.script/protocgen-legacy.sh: Modified to support the new generation requirements.ts/script/generate-exports.js: Enhanced to dynamically generate exports based on the updated directory structure and generation strategies.Implementation Details
The majority of changes in this PR involve file movements to better organize the generated code. The scripts mentioned above have been updated to facilitate these changes and to automate the generation and export of modules.
Notes
Most changes in this PR are related to the restructuring of files and directories; the most relevant code changes are found in the scripts listed above. It is recommended to review these scripts for detailed understanding of the new generation and export processes.