From ece7b8b23746436324d3a99afb336587e98bdf86 Mon Sep 17 00:00:00 2001 From: Andrew Kryczka Date: Mon, 23 Sep 2019 23:37:03 -0700 Subject: [PATCH] c-deps: bump rocksdb for unique cache IDs on Windows Picks up https://github.com/cockroachdb/rocksdb/pull/58. We found a corruption caused by multiple FAT32 files assigned the same block cache key prefix. We don't know the extent to which this problem affects other filesystems or other Windows file ID generation mechanisms. We decided to turn off the reliance on filesystem for generating cache keys on Windows. Instead we use randomization per table reader. This would cause a performance penalty for use cases that open multiple table readers per file, but I believe cockroach is not such a use case. Fixes #40918, fixes #40950. Release justification: Prevents corruption on some Windows filesystems Release note: None --- c-deps/rocksdb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/c-deps/rocksdb b/c-deps/rocksdb index 8978e86a8161..217d7a121d7a 160000 --- a/c-deps/rocksdb +++ b/c-deps/rocksdb @@ -1 +1 @@ -Subproject commit 8978e86a8161157fac5fdc5483934cf55fb2029e +Subproject commit 217d7a121d7ac8db4b742c3fef1e0605af536841