Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All other arguments are ignored when random_mode is set toTrue #57

Open
ajwalkiewicz opened this issue Jan 5, 2023 · 0 comments
Open
Labels
bug Something isn't working python_package Issues related with cochar python package
Milestone

Comments

@ajwalkiewicz
Copy link
Owner

When random_mode is true, all other tags like era, occup_type etc. are ignored.

Then occupation is randomly selected from all possible occupations:

if random_mode:
        return random.choice(cochar.OCCUPATIONS_LIST)

Decide whether it is a bug, and if it is what other arguments should be take under consideration when generating random occupation character.

(it might be kind of a feature, if I want to add an option like: "create total random character"

@ajwalkiewicz ajwalkiewicz added the bug Something isn't working label Jan 5, 2023
@ajwalkiewicz ajwalkiewicz added this to the Gold milestone Jan 5, 2023
@github-project-automation github-project-automation bot moved this to Triage in cochar Jan 5, 2023
@ajwalkiewicz ajwalkiewicz moved this from Triage to Todo in cochar Jan 5, 2023
@ajwalkiewicz ajwalkiewicz added the python_package Issues related with cochar python package label Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python_package Issues related with cochar python package
Projects
Status: Todo
Development

No branches or pull requests

1 participant