From 48efc49c2ab54b33a900883b2287514f42cd4174 Mon Sep 17 00:00:00 2001
From: prateek105 <prateek@ajna.finance>
Date: Tue, 25 Apr 2023 16:59:57 +0530
Subject: [PATCH] Changed epsilon from 1e16 to 1e17 in F1 and F2 invariants

---
 .../invariants/base/BasicInvariants.t.sol     |  4 +--
 .../RegressionTestLiquidationERC20Pool.t.sol  | 30 +++++++++++++++++++
 2 files changed, 32 insertions(+), 2 deletions(-)

diff --git a/tests/forge/invariants/base/BasicInvariants.t.sol b/tests/forge/invariants/base/BasicInvariants.t.sol
index 8696eb9cc..dc43c4583 100644
--- a/tests/forge/invariants/base/BasicInvariants.t.sol
+++ b/tests/forge/invariants/base/BasicInvariants.t.sol
@@ -277,7 +277,7 @@ abstract contract BasicInvariants is BaseInvariants {
             requireWithinDiff(
                 depositAtIndex,
                 IBaseHandler(_handler).fenwickSumAtIndex(bucketIndex),
-                1e16,
+                1e17,
                 "Incorrect deposits in bucket"
             );
         }
@@ -298,7 +298,7 @@ abstract contract BasicInvariants is BaseInvariants {
             requireWithinDiff(
                 depositTillIndex,
                 IBaseHandler(_handler).fenwickSumTillIndex(bucketIndex),
-                1e16,
+                1e17,
                 "Incorrect deposits prefix sum"
             );
         }
diff --git a/tests/forge/regression/ERC20Pool/RegressionTestLiquidationERC20Pool.t.sol b/tests/forge/regression/ERC20Pool/RegressionTestLiquidationERC20Pool.t.sol
index 007ee6ca9..22f10295b 100644
--- a/tests/forge/regression/ERC20Pool/RegressionTestLiquidationERC20Pool.t.sol
+++ b/tests/forge/regression/ERC20Pool/RegressionTestLiquidationERC20Pool.t.sol
@@ -340,4 +340,34 @@ contract RegressionTestLiquidationERC20Pool is LiquidationERC20PoolInvariants {
         _liquidationERC20PoolHandler.pledgeCollateral(115792089237316195423570985008687907853269984665640564039457584007913129639934, 1, 0);
     }
 
+    /*
+        F1 and F2 invariants were failing in `settleAuction` handler with difference between pool deposit and fenwick deposits of <1e17 but >1e16 for deposits of order 1e25
+        Fixed by changing epsilon in F1, F2 from 1e16 to 1e17.
+    */
+    function test_regression_invariant_settle_F1_5() external {
+        _liquidationERC20PoolHandler.settleAuction(0, 28071594006178250681754737955033434168, 2, 0);
+        _liquidationERC20PoolHandler.bucketTake(1730972569841431578573774649270, 10903, false, 1175990817123654468079021581951, 0);
+        _liquidationERC20PoolHandler.addQuoteToken(18695, 12463, 370340205846027014555877964321, 0);
+        _liquidationERC20PoolHandler.takeAuction(631894654554387507015513816632, 16008, 1016878400672168648586524, 0);
+        _liquidationERC20PoolHandler.settleAuction(0, 10186616154253336796368, 115792089237316195423570985008687907853269984665640564039457584007913129639932, 0);
+
+        /* Logs for settleAuction
+            Pool deposit at 2572 after accrue interest                 -> 2032689444945695599645197
+            local Fenwick deposit at 2572 after accrue interest        -> 2032689444928384299157690
+
+            maxSettleable borrower debt                                -> 1004975124378109460799907
+
+            Pool deposit at 2572 after settlePooldebt                  -> 1027714305720790052619170
+            Required Pool deposit after subtracting maxSettleable      -> 1027714320567586138845290
+            Precision error in unscaled remove                         -> 14846796086226120
+
+            local Fenwick deposit at 2572 after settlePooldebt         -> 1027714320550274838357783
+            Required local fenwick after subtracting maxSettleable     -> 1027714320550274838357783
+
+            Final Difference between pool deposit and local fenwick    -> 14829484785738613
+        */
+        invariant_fenwick_depositAtIndex_F1();
+        invariant_fenwick_depositsTillIndex_F2();
+    }
+
 }
\ No newline at end of file