Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows installation via WinGet #79

Closed
spencerwooo opened this issue May 31, 2020 · 18 comments
Closed

Windows installation via WinGet #79

spencerwooo opened this issue May 31, 2020 · 18 comments

Comments

@spencerwooo
Copy link
Contributor

Anything planned for Windows? Preferably: installation via WinGet/Scoop, publishing Windows binaries alongside Linux/macOS on GitHub release, etc.

@ajeetdsouza
Copy link
Owner

Absolutely! It may take a while since I'm not familiar with packaging on Windows - if you have experience, I'd appreciate any help!

@spencerwooo
Copy link
Contributor Author

I believe for zoxide to take advantage of installing via Scoop/WinGet, we must first setup build scripts for Windows on GitHub release. I'll make a PR for the GitHub Action CI first, and if all goes well, I'll poke around and try adding zoxide to Scoop/WinGet's repo next.

(Sorry for the late response...I've been extra busy.)

@ajeetdsouza
Copy link
Owner

Regarding CI, I think it might be better to switch over to the trust project. It has testing, releases on multiple architectures, and a shell-based install script.

I've already done some work on this, I'll ping you here once it's done!

@spencerwooo
Copy link
Contributor Author

Ok, so we won't be using GitHub Actions anymore?

@ajeetdsouza
Copy link
Owner

Probably not - if trust takes care of deployment and installation of binaries, I think we should shift to what they're using.

@ajeetdsouza
Copy link
Owner

@spencerwooo it appears trust's install script relies on rustc unless target is explicitly specified. IMHO, this defeats its purpose.

I think we can go ahead with GitHub Actions for now. Feel free to send in a PR once you have the time!

@ajeetdsouza
Copy link
Owner

ajeetdsouza commented Jul 14, 2020

winget support is currently waiting on microsoft/winget-cli#182 / microsoft/winget-cli#140.

@spencerwooo
Copy link
Contributor Author

spencerwooo commented Jul 27, 2020

I just created a pull request over at scoop's main bucket for zoxide version 0.4.3. If merged, we'll be able to install zoxide with a simple command on Windows:

scoop install zoxide

I'll update the documentations here (if that's ok with you) once it's merged upstream.

@ajeetdsouza
Copy link
Owner

Looks great. Thank you!

@mhetrick
Copy link

mhetrick commented Jun 15, 2021

I just tried installing this via scoop, but I'm unfortunately hitting a hash check failure. Is this something I should report to the Scoop team or is it suitable reporting it here?

image

EDIT: Never mind, it's already been reported to Scoop! ScoopInstaller/Main#2285

@ditsuke
Copy link
Contributor

ditsuke commented Dec 12, 2021

@spencerwooo can you please close this issue?

@ajeetdsouza
Copy link
Owner

@ditsuke I left the issue open because zoxide hasn't been added to WinGet yet. Currently, it's blocked on microsoft/winget-cli#140, but once that happens, I'll close the issue.

@ajeetdsouza ajeetdsouza changed the title Windows installation via WinGet/Scoop? Windows installation via WinGet Feb 16, 2022
@ajeetdsouza ajeetdsouza removed the blocked Blocked on something else. label Sep 27, 2022
@ajeetdsouza
Copy link
Owner

Support for portable exes has been merged into Winget. Tracking the package request here: microsoft/winget-pkgs#80892

@sitiom
Copy link
Contributor

sitiom commented Jan 26, 2023

It's coming!

Once the PR has been merged, Winget Releaser must be set up in this repo to push automatic manifest updates. @ajeetdsouza Are you good with that?

@ajeetdsouza
Copy link
Owner

Yeah, that sounds great!

@kingyue737
Copy link

zoxide now available on winget

image

Installed successfully. Thanks @sitiom !

@sitiom
Copy link
Contributor

sitiom commented Jan 31, 2023

For the Winget Releaser workflow, vedantmgoyal9/winget-releaser#82 would have to be resolved first.

@ajeetdsouza
Copy link
Owner

Thanks @sitiom, really appreciate your work on this! I'll close this issue for now, but I'd be very happy to merge a later PR for auto-updating the package on winget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants