-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/api validation #107
Conversation
Hi @anishmu20, Great job on the validations! Could you please add similar validations to |
hii @Guhapriya01 The changes have been implemented as advised. Validation has been applied only to the newPassword field in the UpdatePasswordDto, ensuring it meets specified security requirements. The currentPassword field remains unvalidated in this DTO, as it is assumed to have already been validated and securely stored in the database. |
Hi @anishmu20, I reviewed your work, and thanks for making those changes! Just make these 2 changes:
Once these changes are made, we can proceed with the merge! Thanks! |
2.Removed @notblank from the role field in the Members DTO
changes done !! |
Hi @anishmu20, Thank you for your thorough work on adding validations across all the key DTOs. The comprehensive validation will greatly enhance data integrity across the API. Level Update: Although initially marked as Level 2, this contribution has been recognized as Level 3 due to the extensive impact and effort involved in implementing validations across multiple DTOs. Looking forward to more collaborations. Thanks again for your contribution! 😊 |
This pull request adds API validation for the Book, Borrowing, and Member modules. I have validated all the API endpoints that accept data related to these modules and have also handled the exceptions associated with these actions. This ensures that the API endpoints return appropriate responses for valid and invalid data, improving the robustness and reliability of the API.
i have tested api using the postmen .
issues #81
![Uploading validation-1.png…](
)