Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ace-builds: empty theme css since v1.9.0 #4897

Closed
gethinwebster opened this issue Aug 16, 2022 · 0 comments · Fixed by #4899
Closed

ace-builds: empty theme css since v1.9.0 #4897

gethinwebster opened this issue Aug 16, 2022 · 0 comments · Fixed by #4899

Comments

@gethinwebster
Copy link

gethinwebster commented Aug 16, 2022

Describe the bug

The output theme css is empty since a few releases, see:

https://github.com/ajaxorg/ace-builds/blob/master/css/theme/dawn.css
vs
https://github.com/ajaxorg/ace-builds/blob/74719e4dd46f0fe8948bb3b383d58fc2348ef128/css/theme/dawn.css

Also on NPM:
https://unpkg.com/browse/[email protected]/css/theme/dawn.css
vs
https://unpkg.com/browse/[email protected]/css/theme/dawn.css

This means that useStrictCSP mode (which loads those theme CSS files directly) is broken (see https://github.com/ajaxorg/ace-builds/blob/master/demo/csp.html) as no theme CSS is loaded.

Expected Behavior

The theme CSS files should be populated

Current Behavior

The theme CSS files are empty

Reproduction Steps

Install any version of ace-builds from 1.9 onwards

Possible Solution

No response

Additional Information/Context

No response

Ace Version

1.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants