Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds missed functions into php_completions.js #4726

Merged
merged 3 commits into from
May 30, 2022
Merged

Adds missed functions into php_completions.js #4726

merged 3 commits into from
May 30, 2022

Conversation

WinterSilence
Copy link
Contributor

@WinterSilence WinterSilence commented May 30, 2022

Issue #, if available:
#4546

Description of changes:
Adds missed functions (only popular)

  • By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Add missed functions (only popular)
@WinterSilence WinterSilence changed the title Update php_completions.js Adds missed functions (only popular) in php_completions.js May 30, 2022
@WinterSilence WinterSilence changed the title Adds missed functions (only popular) in php_completions.js Adds missed functions into php_completions.js May 30, 2022
@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #4726 (5e488a0) into master (8f49d65) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4726      +/-   ##
==========================================
- Coverage   71.19%   71.10%   -0.09%     
==========================================
  Files         553      554       +1     
  Lines       55598    55693      +95     
  Branches    10392    10421      +29     
==========================================
+ Hits        39584    39602      +18     
- Misses      16014    16091      +77     
Flag Coverage Δ
unittests 71.10% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/ace/mode/php_completions.js 26.08% <ø> (ø)
lib/ace/worker/mirror.js 51.35% <0.00%> (-9.26%) ⬇️
lib/ace/lib/dom.js 83.59% <0.00%> (-1.27%) ⬇️
lib/ace/ext/code_lens.js 91.60% <0.00%> (-0.48%) ⬇️
lib/ace/keyboard/textinput.js 75.45% <0.00%> (-0.26%) ⬇️
lib/ace/autocomplete/popup.js 78.19% <0.00%> (ø)
lib/ace/lib/es6-shim.js 15.85% <0.00%> (ø)
lib/ace/editor.js 79.66% <0.00%> (+0.01%) ⬆️
lib/ace/mouse/mouse_handler.js 83.59% <0.00%> (+0.26%) ⬆️
lib/ace/commands/command_manager.js 82.35% <0.00%> (+0.53%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f49d65...5e488a0. Read the comment docs.

lib/ace/mode/php_completions.js Outdated Show resolved Hide resolved
@andrewnester andrewnester merged commit 7d5f4b8 into ajaxorg:master May 30, 2022
@WinterSilence WinterSilence deleted the patch-1 branch May 30, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants