-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Robot Framework syntax highlighting #4614
Conversation
Looks like tests are failing because of using lookbehind in a regex. If you are not planning to support safari https://caniuse.com/?search=Lookbehind, i can modify the test runner to allow this failure on old versions of node and merge this pull request. |
I think I've managed to remove the lookbehinds in the regexes, and the functionality is the same, so no worries on that one! However, I'm now trying to add some snippets to this, but for some reason they aren't autocompleting in the kitchen sink demo, I've tested the python ones and they are completing correctly, but for some reason the robot framework ones aren't. Could you please look at the latest commit and advise as to what to do here? |
Can you provide any assistance with this please? |
Sorry i have missed this, the snippets in your commit don't work because they are indented with spaces instead of tabs. |
Thanks for the help, I've changed the indentation to tabs and now the snippets behave as expected! Also fixed an error where some keywords were getting highlighted in the middle of words. I think this is good to go for merging now! |
Codecov Report
@@ Coverage Diff @@
## master #4614 +/- ##
==========================================
+ Coverage 71.01% 71.19% +0.18%
==========================================
Files 546 555 +9
Lines 55303 55597 +294
Branches 10376 10398 +22
==========================================
+ Hits 39272 39581 +309
+ Misses 16031 16016 -15
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Issue #, if available:
#4489
Description of changes:
Add Robot Framework syntax highlighting.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.