Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file / pipe utility functions to Win32MppImpls #129

Open
sschuberth opened this issue Oct 4, 2023 · 1 comment
Open

Add file / pipe utility functions to Win32MppImpls #129

sschuberth opened this issue Oct 4, 2023 · 1 comment

Comments

@sschuberth
Copy link
Contributor

sschuberth commented Oct 4, 2023

when (getTermProgram()) { isn't reached even if output is not redirected to a file.

That's correct. Whenever we're in a situation where it's not possible to detect whether output is interactive or not (which is the case for Git for Windows), we should assume it is not, in order to avoid printing ANSI codes to a file.

Git for Windows itself has this detection mechanism

Yeah, that was the workaround I mentioned that we could add to Win32MppImpls in a separate PR.

Originally posted by @ajalt in #127 (comment)

@sschuberth
Copy link
Contributor Author

This is a prerequisite to solve #38.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant