Better support for enum types #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ajalt there seems to be a problem with the build:
|
qw3ry
commented
Aug 30, 2019
| @@ -1,7 +1,7 @@ | |||
| language: java | |||
|
|
|||
| jdk: | |||
| - oraclejdk8 | |||
| - openjdk8 | |||
There was a problem hiding this comment.
If this is a problem, I'll revert this, but it fixed the travis build (see https://travis-ci.community/t/install-of-oracle-jdk-8-failing/3038/3)
ajalt
approved these changes
Aug 30, 2019
| @@ -1,7 +1,7 @@ | |||
| language: java | |||
|
|
|||
| jdk: | |||
| - oraclejdk8 | |||
| - openjdk8 | |||
sschuberth
added a commit
to sschuberth/clikt
that referenced
this pull request
Sep 24, 2019
|
I'm looking forward to this! Any ETA for a regular release which includes the |
ajalt
pushed a commit
that referenced
this pull request
Sep 24, 2019
|
@sschuberth I had been waiting for feedback on #80, but I can make a smaller release without that PR this week. |
|
That'd be great @ajalt, thanks! |
|
@sschuberth version 2.2.0 has been released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added
RawArgument.enum()andRawOption.enum()to support enum types.I added a test class. I updated the docs, as well as the changelog
Advantages over
choice("A" to A, "B" to B):Cto the enum?)