Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Gists to PrismJS #34

Open
aitchiss opened this issue Jan 31, 2020 · 0 comments
Open

Convert Gists to PrismJS #34

aitchiss opened this issue Jan 31, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest 🎃 Issues perfect for participants in Hacktoberfest help wanted Extra attention is needed

Comments

@aitchiss
Copy link
Owner

aitchiss commented Jan 31, 2020

Code snippets were originally created in Gists, partly because they behaved nicely with screen readers. The downsides however are:

  • lack of control over styling and syntax highlighting, many of which are throwing warnings in a11y audit tools (the contrast is fine but extensions are unable to determine the background colour)
  • unnecessary noise on the page with links to GitHub and that annoying heart emoji. Could be fixed by overriding their CSS but the better solution would be to move away entirely

PrismJS does everything we need in an accessible way.

Jobs to be done:

  • Create an accessible style for Prism code snippets that fits in with the overall UYA palette
  • Page by page port gists to prism code snippets (each article/page ported to prism code snippets should be a single pull request)
@aitchiss aitchiss added the enhancement New feature or request label Jan 31, 2020
@aitchiss aitchiss changed the title Investigate alternatives to Gist Convert Gists to PrismJS Jun 14, 2020
@aitchiss aitchiss added good first issue Good for newcomers help wanted Extra attention is needed labels Jun 14, 2020
@aitchiss aitchiss added the hacktoberfest 🎃 Issues perfect for participants in Hacktoberfest label Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest 🎃 Issues perfect for participants in Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant