Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn users when trying to save rule without target domain #69

Closed
airtower-luna opened this issue Aug 14, 2022 · 0 comments · Fixed by #71
Closed

Warn users when trying to save rule without target domain #69

airtower-luna opened this issue Aug 14, 2022 · 0 comments · Fixed by #71
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@airtower-luna
Copy link
Owner

With the code currently in #68 the settings page will silently discard any rules without a target domain while saving. This is correct behavior (because rules must have a target domain) but may be confusing to users.

A warning message should appear when the user tries to save a rule without a target domain.

@airtower-luna airtower-luna added enhancement New feature or request good first issue Good for newcomers labels Aug 14, 2022
@airtower-luna airtower-luna added this to the 1.0 milestone Aug 14, 2022
@airtower-luna airtower-luna self-assigned this Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant