Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flake8 violations for all files in the asv/extern/ directory #1066

Closed
dorothykiz1 opened this issue Mar 1, 2022 · 4 comments
Closed

Comments

@dorothykiz1
Copy link
Contributor

dorothykiz1 commented Mar 1, 2022

We are trying to clean out all the files to follow Flake8 standards

Use this guide below to install flake8 and how to use it.
Flake8 guide

Here are a few steps to follow:

  • You will be required to remove the files you would like to work on from the setup. cfg file under the extend attribute .
  • Create a virtual environment virtualenv venv venv will be the name for the environment and activate it by running source venv/bin/activate these commands are dependent on the operating system. (These are Linux commands, you can find for windows and macOS online)
  • Run pip install flake8 to install flake8
  • Run flake8 --exclude="" asv/extern/ .
  • Work on all the highlighted errors

Expected errors to be fixed:

asv/extern/minify_json.py:17:1: E302 expected 2 blank lines, found 1
asv/extern/minify_json.py:44:23: E261 at least two spaces before inline comment
asv/extern/minify_json.py:92:17: E128 continuation line under-indented for visual indent
asv/extern/minify_json.py:93:13: E124 closing bracket does not match visual indentation
asv/extern/minify_json.py:99:17: E128 continuation line under-indented for visual indent
asv/extern/minify_json.py:100:13: E124 closing bracket does not match visual indentation
asv/extern/minify_json.py:116:17: E128 continuation line under-indented for visual indent
asv/extern/minify_json.py:117:13: E124 closing bracket does not match visual indentation
asv/extern/minify_json.py:125:17: E128 continuation line under-indented for visual indent
asv/extern/minify_json.py:126:13: E124 closing bracket does not match visual indentation
asv/extern/asizeof.py:216:14: E221 multiple spaces before operator
asv/extern/asizeof.py:217:14: E221 multiple spaces before operator
asv/extern/asizeof.py:347:16: E126 continuation line over-indented for hanging indent
asv/extern/asizeof.py:507:35: E127 continuation line over-indented for visual indent
asv/extern/asizeof.py:854:20: E127 continuation line over-indented for visual indent
asv/extern/asizeof.py:855:20: E127 continuation line over-indented for visual indent
asv/extern/asizeof.py:856:20: E127 continuation line over-indented for visual indent
asv/extern/asizeof.py:857:20: E127 continuation line over-indented for visual indent
asv/extern/asizeof.py:881:12: E128 continuation line under-indented for visual indent
asv/extern/asizeof.py:996:20: E127 continuation line over-indented for visual indent
asv/extern/asizeof.py:997:20: E127 continuation line over-indented for visual indent
asv/extern/asizeof.py:998:20: E127 continuation line over-indented for visual indent
asv/extern/asizeof.py:1148:17: E126 continuation line over-indented for hanging indent
asv/extern/asizeof.py:1274:21: E127 continuation line over-indented for visual indent
asv/extern/asizeof.py:1311:22: E127 continuation line over-indented for visual indent
asv/extern/asizeof.py:1351:100: E501 line too long (102 > 99 characters)
asv/extern/asizeof.py:1483:43: E128 continuation line under-indented for visual indent
asv/extern/asizeof.py:1499:29: E127 continuation line over-indented for visual indent
asv/extern/asizeof.py:1500:29: E127 continuation line over-indented for visual indent
asv/extern/asizeof.py:1742:9: E221 multiple spaces before operator
asv/extern/asizeof.py:1745:10: E221 multiple spaces before operator
asv/extern/asizeof.py:1746:9: E221 multiple spaces before operator
asv/extern/asizeof.py:1796:16: E241 multiple spaces after ':'
asv/extern/asizeof.py:1797:14: E241 multiple spaces after ':'
asv/extern/asizeof.py:1798:15: E241 multiple spaces after ':'
asv/extern/asizeof.py:1800:15: E241 multiple spaces after ':'
asv/extern/asizeof.py:1801:16: E241 multiple spaces after ':'
asv/extern/asizeof.py:1802:16: E241 multiple spaces after ':'
asv/extern/asizeof.py:1830:16: E128 continuation line under-indented for visual indent
asv/extern/asizeof.py:1869:22: E127 continuation line over-indented for visual indent
asv/extern/asizeof.py:1888:36: E127 continuation line over-indented for visual indent
asv/extern/asizeof.py:1889:54: E226 missing whitespace around arithmetic operator
asv/extern/asizeof.py:1890:41: E226 missing whitespace around arithmetic operator
asv/extern/asizeof.py:1906:12: E221 multiple spaces before operator
asv/extern/asizeof.py:1907:12: E221 multiple spaces before operator
asv/extern/asizeof.py:1908:11: E221 multiple spaces before operator
asv/extern/asizeof.py:1909:11: E221 multiple spaces before operator
asv/extern/asizeof.py:1914:12: E221 multiple spaces before operator
asv/extern/asizeof.py:1915:12: E221 multiple spaces before operator
asv/extern/asizeof.py:1916:12: E221 multiple spaces before operator
asv/extern/asizeof.py:1918:11: E221 multiple spaces before operator
asv/extern/asizeof.py:1919:12: E221 multiple spaces before operator
asv/extern/asizeof.py:1920:11: E221 multiple spaces before operator
asv/extern/asizeof.py:1921:10: E221 multiple spaces before operator
asv/extern/asizeof.py:1922:10: E221 multiple spaces before operator
asv/extern/asizeof.py:1923:12: E221 multiple spaces before operator
asv/extern/asizeof.py:1925:11: E221 multiple spaces before operator
asv/extern/asizeof.py:1926:12: E221 multiple spaces before operator
asv/extern/asizeof.py:1927:11: E221 multiple spaces before operator
asv/extern/asizeof.py:1928:10: E221 multiple spaces before operator
asv/extern/asizeof.py:1929:12: E221 multiple spaces before operator
asv/extern/asizeof.py:1930:11: E221 multiple spaces before operator
asv/extern/asizeof.py:1965:33: E127 continuation line over-indented for visual indent
asv/extern/asizeof.py:1966:32: E127 continuation line over-indented for visual indent
asv/extern/asizeof.py:2049:54: E127 continuation line over-indented for visual indent
asv/extern/asizeof.py:2050:55: E127 continuation line over-indented for visual indent
asv/extern/asizeof.py:2058:31: E127 continuation line over-indented for visual indent
asv/extern/asizeof.py:2265:27: E127 continuation line over-indented for visual indent
asv/extern/asizeof.py:2294:100: E501 line too long (104 > 99 characters)
asv/extern/asizeof.py:2298:100: E501 line too long (127 > 99 characters)
asv/extern/asizeof.py:2346:100: E501 line too long (112 > 99 characters)
asv/extern/asizeof.py:2372:100: E501 line too long (100 > 99 characters)
asv/extern/asizeof.py:2407:39: E127 continuation line over-indented for visual indent
asv/extern/asizeof.py:2427:21: E127 continuation line over-indented for visual indent
asv/extern/asizeof.py:2428:21: E127 continuation line over-indented for visual indent
asv/extern/asizeof.py:2490:19: E127 continuation line over-indented for visual indent
asv/extern/asizeof.py:2890:18: E127 continuation line over-indented for visual indent
asv/extern/__init__.py:1:1: W391 blank line at end of file
@datapythonista
Copy link
Member

Thanks @dorothykiz1 for creating those, very helpful, and the description is very clear.

I guess extern can mean that the code in the directory has been copied from elsewhere. Let's give low priority to this issue for now. Maybe it could make sense before fixing the style errors, to have a look and see where the code was copied from, and if things changed since it was copied (maybe there is a library now, or a newer version of the script...).

@HaoZeke
Copy link
Member

HaoZeke commented Mar 19, 2023

This can be closed now that extern has been removed as of #1234

@datapythonista
Copy link
Member

Thanks @HaoZeke

@dorothykiz1
Copy link
Contributor Author

Thank You @HaoZeke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants