Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AIAP: Passwords and tokens are stored as plaintext #636

Closed
ian-howell opened this issue Sep 15, 2021 · 3 comments
Closed

AIAP: Passwords and tokens are stored as plaintext #636

ian-howell opened this issue Sep 15, 2021 · 3 comments
Assignees
@sirajyasin
Labels
bug Something isn't working priority/critical Items critical to be implemented, usually by the next release size m
Milestone
v2.1

Comments

@ian-howell
Copy link
Contributor

Describe the bug
When providing a password or personal access token to AIAP, the value is used as an environment variable, meaning that it is easily accessible via a kubectl describe of the pod

Steps To Reproduce
Deploy an instance of AIAP with a specified password.

Expected behavior
Passwords should not be visibile
@ian-howell ian-howell added bug Something isn't working triage Needs evaluation by project members labels Sep 15, 2021
@ian-howell ian-howell self-assigned this Sep 15, 2021
@jezogwza jezogwza added priority/critical Items critical to be implemented, usually by the next release and removed triage Needs evaluation by project members labels Sep 22, 2021
@jezogwza jezogwza added this to the v2.1 milestone Sep 22, 2021
@sirajyasin
Copy link
Contributor

This PS (https://review.opendev.org/c/airship/airshipctl/+/809290) will address this issue.

@ian-howell ian-howell assigned sirajyasin and unassigned ian-howell Sep 23, 2021
airshipbot pushed a commit that referenced this issue Sep 28, 2021
@sirajyasin
Allow pulling from a private airshipctl repo
9070704 
* Added the logic to support pulling airshipctl from a
  private github repo with basic http authentication.

* Added Username, Password in secrets

Relates-To: #632
Relates-To: #636
Change-Id: If1a1bbfaf9ce543cf35377d367b70676f9e3e9ef
@sirajyasin
Copy link
Contributor

The related PS https://review.opendev.org/c/airship/airshipctl/+/809290 is merged. This issue can be marked completed

@eak13
Copy link

eak13 commented Sep 29, 2021

Closing per above.

@eak13 eak13 closed this as completed Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sirajyasin sirajyasin

Labels
bug Something isn't working priority/critical Items critical to be implemented, usually by the next release size m
Projects
None yet
Milestone
v2.1
Development

No branches or pull requests
4 participants
@eak13 @jezogwza @ian-howell @sirajyasin